[
https://issues.apache.org/jira/browse/CASSANDRA-14002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16245359#comment-16245359
]
Marcus Eriksson commented on CASSANDRA-14002:
---------------------------------------------
thanks for the review!
bq. 50% faster is a bigger win than I expected when I saw it in profiling
yeah, I think the biggest win is actually that guavas streaming hashers
actually buffer the data to be hashed instead of hashing them byte-for-byte:
https://github.com/google/guava/blob/v23.3/guava/src/com/google/common/hash/AbstractStreamingHasher.java#L34
I'm rerunning the dtests
[here|https://builds.apache.org/view/A-D/view/Cassandra/job/Cassandra-devbranch-dtest/424/]
before committing
> Don't use SHA256 when building merkle trees
> -------------------------------------------
>
> Key: CASSANDRA-14002
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14002
> Project: Cassandra
> Issue Type: Bug
> Reporter: Marcus Eriksson
> Assignee: Marcus Eriksson
> Fix For: 4.x
>
>
> We should avoid using SHA-2 when building merkle trees as we don't need a
> cryptographic hash function for this.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
