[
https://issues.apache.org/jira/browse/CASSANDRA-14083?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Paulo Motta updated CASSANDRA-14083:
------------------------------------
Description:
We currently invalidate disk boundaries whenever [instantiating a new
replication
strategy|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/db/Keyspace.java#L359],
but this is done whenever [updating keyspace
settings|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/db/Keyspace.java#L187].
Computing new boundaries is expensive and unnecessarily invalidating them will
cause {{DiskBoundaries}} consumers to also invalidate their work unnecessarily.
For instance, after CASSANDRA-13948 the {{CompactionStrategyManager}} will
reload all compaction strategies when the boundaries are invalidated.
In this case, we should only invalidate the disk boundaries when the
replication settings change to avoid doing unnecessary work.
> Avoid invalidating disk boundaries unnecessarily
> ------------------------------------------------
>
> Key: CASSANDRA-14083
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14083
> Project: Cassandra
> Issue Type: Bug
> Reporter: Paulo Motta
> Assignee: Paulo Motta
>
> We currently invalidate disk boundaries whenever [instantiating a new
> replication
> strategy|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/db/Keyspace.java#L359],
> but this is done whenever [updating keyspace
> settings|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/db/Keyspace.java#L187].
>
> Computing new boundaries is expensive and unnecessarily invalidating them
> will cause {{DiskBoundaries}} consumers to also invalidate their work
> unnecessarily. For instance, after CASSANDRA-13948 the
> {{CompactionStrategyManager}} will reload all compaction strategies when the
> boundaries are invalidated.
> In this case, we should only invalidate the disk boundaries when the
> replication settings change to avoid doing unnecessary work.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
