[
https://issues.apache.org/jira/browse/CASSANDRA-14083?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Paulo Motta updated CASSANDRA-14083:
------------------------------------
Status: Patch Available (was: Open)
The cached disk boundary invalidation mentioned above went into
CASSANDRA-13948. This also includes waiting for pending ranges when computing
new disk boundaries which was missing from CASSANDRA-13948.
Setting to Patch Available, test failures look unrelated:
||3.11||trunk||
|[branch|https://github.com/apache/cassandra/compare/cassandra-3.11...pauloricardomg:3.11-14083]|[branch|https://github.com/apache/cassandra/compare/trunk...pauloricardomg:trunk-14083]|
|[testall|https://issues.apache.org/jira/secure/attachment/12902169/3.11-14083-testall.png]|[testall|https://issues.apache.org/jira/secure/attachment/12902167/trunk-14083-testall.png]|
|[dtest|https://issues.apache.org/jira/secure/attachment/12902170/3.11-14083-dtest.png]|[dtest|https://issues.apache.org/jira/secure/attachment/12902167/trunk-14083-testall.png]|
> Avoid invalidating disk boundaries unnecessarily
> ------------------------------------------------
>
> Key: CASSANDRA-14083
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14083
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Paulo Motta
> Assignee: Paulo Motta
> Attachments: 3.11-14083-dtest.png, 3.11-14083-testall.png,
> trunk-14083-dtest.png, trunk-14083-testall.png
>
>
> We currently invalidate disk boundaries whenever [instantiating a new
> replication
> strategy|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/db/Keyspace.java#L359],
> but this is done whenever [updating keyspace
> settings|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/db/Keyspace.java#L187].
>
> Computing new boundaries is expensive and unnecessarily invalidating them
> will cause {{DiskBoundaries}} consumers to also invalidate their work
> unnecessarily. For instance, after CASSANDRA-13948 the
> {{CompactionStrategyManager}} will reload all compaction strategies when the
> boundaries are invalidated.
> In this case, we should only invalidate the disk boundaries when the
> replication settings change to avoid doing unnecessary work.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
