[
https://issues.apache.org/jira/browse/CASSANDRA-14005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16336640#comment-16336640
]
Vincent Dumont commented on CASSANDRA-14005:
--------------------------------------------
Hi Edward,
Thanks for taking a look. I understand the benefit of having a warn/error log,
but I'm unclear why we wouldn't propagate (ie: rethrow) the ExecutionException?
The concern is that from a process standpoint, if the process succeeds you'd
think that the writer succeeded but even with the patch you'd at best see a
just log message (and a successful process).
Even for TimeoutExceptions, how are retries triggered if the TimeoutException
isn't rethrown?
Thanks
> CqlBulkRecordWriter swallows exceptions
> ---------------------------------------
>
> Key: CASSANDRA-14005
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14005
> Project: Cassandra
> Issue Type: Bug
> Components: CQL
> Reporter: Vincent Dumont
> Priority: Major
> Attachments: CASSANDRA-14005.patch
>
>
> The {{close()}} method in {{CqlBulkRecordWriter}} has the following:
> {code:java}
> try
> {
> future.get(1000, TimeUnit.MILLISECONDS);
> break;
> }
> catch (ExecutionException | TimeoutException te)
> {
> if (null != progress)
> progress.progress();
> if (null != context)
> HadoopCompat.progress(context);
> }
> catch (InterruptedException e)
> {
> throw new IOException(e);
> }
> {code}
> And so any exception that happens when uploading SSTables silently gets
> swallowed and not surfaced.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
