mck commented on CASSANDRA-13457:

{quote}Can we avoid the static fields? So to be avoiding adding to the 
CASSANDRA-7837 problems… I don't think C* has a better habit in place for this? 
But a singleton would be one better than all static fields…
I can't see DiagnosticEventService not being a singleton, given the breadth of 
its context.
But if the static fields were removed (a la the spirit of CASSANDRA-7840), it 
would at least provide more options for unit testing and an ability to swap out 
the DiagnosticEventService implementation (eg like is done in \{{Tracing}}).

> Diag. Events: Add base classes
> ------------------------------
>                 Key: CASSANDRA-13457
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-13457
>             Project: Cassandra
>          Issue Type: Sub-task
>          Components: Core, Observability
>            Reporter: Stefan Podkowinski
>            Assignee: Stefan Podkowinski
>            Priority: Major
> Base ticket for adding classes that will allow you to implement and subscribe 
> to events.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

Reply via email to