[ https://issues.apache.org/jira/browse/CASSANDRA-13653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16415036#comment-16415036 ]
Jeff Jirsa commented on CASSANDRA-13653: ---------------------------------------- [~djoshi3] - [~dbrosius] specifically recommended using reflectionToString - most of the toString methods here won't be in a hot path, and really the only point of this is to make debugging slightly easier. If any of these ARE called in any sort of meaningfully hot path, they shouldn't use reflection, but we should try to verify that before proceeding. > Create meaningful toString() methods > ------------------------------------ > > Key: CASSANDRA-13653 > URL: https://issues.apache.org/jira/browse/CASSANDRA-13653 > Project: Cassandra > Issue Type: Bug > Reporter: Jeff Jirsa > Assignee: Jogesh Anand > Priority: Trivial > Labels: lhf, low-hanging-fruit > > True low-hanging fruit, good for a first-time contributor: > There are a lot of classes without meaningful {{toString()}} implementations. > Some of these would be very nice to have for investigating bug reports. > Some good places to start: > - CQL3 statements (UpdateStatement, DeleteStatement, etc), QueryOptions, and > Restrictions > Some packages not to worry about: > - Deep internals that don't already have them > (org.apache.cassandra.db.rows/partitions/etc) -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org