[
https://issues.apache.org/jira/browse/CASSANDRA-13653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16415042#comment-16415042
]
Jogesh Anand commented on CASSANDRA-13653:
------------------------------------------
[~djoshi3] - Thanks for the feedback. I went through the links provided and my
reasoning is based on these two points. One, this will be used for debugging
purposes and there are not many places where we would log/print the entire
class. Second, if there are additions/deletions to the class variables
developers need not worry about the toString() implementation. Having said that
please help me understand if there will be plenty of logging in cql3.statements
package in which case this might effect performance as you mentioned.
ps:sorry for the inconvenience on the patch. Will address Nate's feedback
> Create meaningful toString() methods
> ------------------------------------
>
> Key: CASSANDRA-13653
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13653
> Project: Cassandra
> Issue Type: Bug
> Reporter: Jeff Jirsa
> Assignee: Jogesh Anand
> Priority: Trivial
> Labels: lhf, low-hanging-fruit
>
> True low-hanging fruit, good for a first-time contributor:
> There are a lot of classes without meaningful {{toString()}} implementations.
> Some of these would be very nice to have for investigating bug reports.
> Some good places to start:
> - CQL3 statements (UpdateStatement, DeleteStatement, etc), QueryOptions, and
> Restrictions
> Some packages not to worry about:
> - Deep internals that don't already have them
> (org.apache.cassandra.db.rows/partitions/etc)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
