[ 
https://issues.apache.org/jira/browse/CASSANDRA-7839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16420995#comment-16420995
 ] 

Jason Brown edited comment on CASSANDRA-7839 at 3/30/18 10:09 PM:
------------------------------------------------------------------

Also, I realized the current call site where {{IEndpointSnitch#validate}} is 
called from is not very good: it uses cluster metadata from gossip, however 
gossip has not been enabled before the call site! We have, however, executed 
the shadow round of gossip, and we have the cluster metadata after the shadow 
round completes. Thus, at those call sites, with the shadow round data, we 
should call {{IEndpointSnitch#validate}}. Added a commit for that


was (Author: jasobrown):
Also, I realized the current call site where {{IEndpointSnitch#validate}} is 
called from is not very good: it uses cluster metadata from gossip, however 
gossip has not been enabled before the call site! We have, however, executed 
the shadow round of gossip, and we have the cluster metadata after the shadow 
round completes. Thus, at those call sites, with the shadow round data, we 
should call {{IEndpointSnitch#validate}}. Added a patch for that

> Support standard EC2 naming conventions in Ec2Snitch
> ----------------------------------------------------
>
>                 Key: CASSANDRA-7839
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-7839
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Gregory Ramsperger
>            Assignee: Jason Brown
>            Priority: Major
>              Labels: docs-impacting
>         Attachments: CASSANDRA-7839-aws-naming-conventions.patch
>
>
> The EC2 snitches use datacenter and rack naming conventions inconsistent with 
> those presented in Amazon EC2 APIs as region and availability zone. A 
> discussion of this is found in CASSANDRA-4026. This has not been changed for 
> valid backwards compatibility reasons. Using SnitchProperties, it is possible 
> to switch between the legacy naming and the full, AWS-style naming. 
> Proposal:
> * introduce a property (ec2_naming_scheme) to switch naming schemes.
> * default to current/legacy naming scheme
> * add support for a new scheme ("standard") which is consistent AWS 
> conventions
> ** data centers will be the region name, including the number
> ** racks will be the availability zone name, including the region name
> Examples:
> * * legacy* : datacenter is the part of the availability zone name preceding 
> the last "\-" when the zone ends in \-1 and includes the number if not \-1. 
> Rack is the portion of the availability zone name following  the last "\-".
> ** us-west-1a => dc: us-west, rack: 1a
> ** us-west-2b => dc: us-west-2, rack: 2b; 
> * *standard* : datacenter is the part of the availability zone name preceding 
> zone letter. rack is the entire availability zone name.
> ** us-west-1a => dc: us-west-1, rack: us-west-1a
> ** us-west-2b => dc: us-west-2, rack: us-west-2b; 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

Reply via email to