[
https://issues.apache.org/jira/browse/CASSANDRA-13426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16546511#comment-16546511
]
Sam Tunnicliffe commented on CASSANDRA-13426:
---------------------------------------------
{{TableMetadata::equalsWithoutColumns}} does include columns, which makes deep
diffs appear shallow. I appreciate the horror of the rebase, so I'm not saying
we should definitely block commit on it, but this sort of thing is certainly a
good argument for adding tests sooner rather than later.
The failing dtest seems consistent rather than flaky and I can't get it to
fail on trunk, so it seems like it could be a regression.
2 very minor nits:
* The comment on {{Keyspaces::diff}} has {{DEEP}} and {{SHALLOW}} backwards,
and is slightly out of date anyway (wrt to Mode). IMO you could probably just
drop this explanation from here as {{KeyspacesDiff::diff}} doesn't directly
refer to it anymore and it is documented in {{Difference}} already.
* New unused import in ViewMetadata.
> Make all DDL statements idempotent and not dependent on global state
> --------------------------------------------------------------------
>
> Key: CASSANDRA-13426
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13426
> Project: Cassandra
> Issue Type: Sub-task
> Components: Distributed Metadata
> Reporter: Aleksey Yeschenko
> Assignee: Aleksey Yeschenko
> Priority: Major
> Fix For: 4.0
>
>
> A follow-up to CASSANDRA-9425 and a pre-requisite for CASSANDRA-10699.
> It's necessary for the latter to be able to apply any DDL statement several
> times without side-effects. As part of the ticket I think we should also
> clean up validation logic and our error texts. One example is varying
> treatment of missing keyspace for DROP TABLE/INDEX/etc. statements with IF
> EXISTS.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
