[
https://issues.apache.org/jira/browse/CASSANDRA-9608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16551658#comment-16551658
]
Jason Brown commented on CASSANDRA-9608:
----------------------------------------
Sorry for the delay in getting back to this, [~snazy]. Here's the comments for
the last part of my first pass of review.
bq. JMXServerUtils
Yeah, followup ticket wfm
bq. Windows files
same, especially as we're considering java 11 experimental
Last thing to comment on is the [java11 version of
{{AtomicBTreePartitionBase}}|https://github.com/snazy/cassandra/blob/014b837042309c593eafbf46f78f1d82daf83343/src/java11/org/apache/cassandra/db/partitions/AtomicBTreePartitionBase.java].
I've spent several days (again) seeing if I can come up with anything better
than the CAS/sleep, and I still can't, especially given this is the uncommon
path for partition updates to the memtable. Lacking any other breakthoughs in
thought, I'm largely fine with this. Maybe somelike [~benedict] can take a
quick look and offer any suggestions we're not seeing?
Other than that, I think we're looking pretty good. I'll try to knock a second
round of review, and do some local testing, within the next few days.
> Support Java 11
> ---------------
>
> Key: CASSANDRA-9608
> URL: https://issues.apache.org/jira/browse/CASSANDRA-9608
> Project: Cassandra
> Issue Type: Task
> Reporter: Robert Stupp
> Assignee: Robert Stupp
> Priority: Minor
> Fix For: 4.x
>
> Attachments: jdk_9_10.patch
>
>
> This ticket is intended to group all issues found to support Java 9 in the
> future.
> From what I've found out so far:
> * Maven dependency {{com.sun:tools:jar:0}} via cobertura cannot be resolved.
> It can be easily solved using this patch:
> {code}
> - <dependency groupId="net.sourceforge.cobertura"
> artifactId="cobertura"/>
> + <dependency groupId="net.sourceforge.cobertura"
> artifactId="cobertura">
> + <exclusion groupId="com.sun" artifactId="tools"/>
> + </dependency>
> {code}
> * Another issue is that {{sun.misc.Unsafe}} no longer contains the methods
> {{monitorEnter}} + {{monitorExit}}. These methods are used by
> {{o.a.c.utils.concurrent.Locks}} which is only used by
> {{o.a.c.db.AtomicBTreeColumns}}.
> I don't mind to start working on this yet since Java 9 is in a too early
> development phase.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
