[
https://issues.apache.org/jira/browse/CASSANDRA-9608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16528106#comment-16528106
]
Jason Brown commented on CASSANDRA-9608:
----------------------------------------
I've taken a first pass through the scripts and build.xml parts (all the
non-code stuff), and on the whole it's looking pretty good. I've made a few
minor comments on the PR, but I have these points, as well:
- you have the java version check code copied across several scripts, and it
looks like clients.in.sh is used by many other scripts (so I guess this is the
'canonical' location?). Should we have the main bin/cassandra.in.sh use this?
Maybe the one in tools/bin, as well? Also, I don't think (I may be wrong) the
cassandra.in.sh in the debian/redhat can call the clients.in.sh script. wdyt?
- the changes you made to cassandra-env.sh need to be made to
cassandra-env.ps1 (wrt java version checking). There's also some Windows
{{.bat}} files in the code base. Can you check to see if they need updates, as
well?
- can we add a simple note to conf/jvm8-clients.options, with something like
this: "this file is intentionaly blank". or should we just get rid of it, and
add it when we actually need it?
I suspect the code will be easier to review, so hopefully I can knock that out
in short order.
> Support Java 11
> ---------------
>
> Key: CASSANDRA-9608
> URL: https://issues.apache.org/jira/browse/CASSANDRA-9608
> Project: Cassandra
> Issue Type: Task
> Reporter: Robert Stupp
> Assignee: Robert Stupp
> Priority: Minor
> Fix For: 4.x
>
> Attachments: jdk_9_10.patch
>
>
> This ticket is intended to group all issues found to support Java 9 in the
> future.
> From what I've found out so far:
> * Maven dependency {{com.sun:tools:jar:0}} via cobertura cannot be resolved.
> It can be easily solved using this patch:
> {code}
> - <dependency groupId="net.sourceforge.cobertura"
> artifactId="cobertura"/>
> + <dependency groupId="net.sourceforge.cobertura"
> artifactId="cobertura">
> + <exclusion groupId="com.sun" artifactId="tools"/>
> + </dependency>
> {code}
> * Another issue is that {{sun.misc.Unsafe}} no longer contains the methods
> {{monitorEnter}} + {{monitorExit}}. These methods are used by
> {{o.a.c.utils.concurrent.Locks}} which is only used by
> {{o.a.c.db.AtomicBTreeColumns}}.
> I don't mind to start working on this yet since Java 9 is in a too early
> development phase.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
