[
https://issues.apache.org/jira/browse/CASSANDRA-14806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16660450#comment-16660450
]
Marcus Eriksson commented on CASSANDRA-14806:
---------------------------------------------
this looks good to me, a few comments (mostly circle-ci-config-feature-related);
* It would be nice to at some point get rid of the {{<<:}} stuff as it is not
really covered in the circleci docs, this probably needs additional circleci
features though
* We can probably remove {{with_dtest_jobs_only}} now? Or do you have a good
use case for it?
https://github.com/krummas/cassandra/commit/8e6732694648cdf69a64bcbf416226ddae1f95b7
* We should probably allow {{test-compression}} to be run in parallel, this
requires build.xml changes though, so we can do it in a later ticket
* Maybe we could ship a {{.circleci/high_resource.patch}} so that enabling the
high resource would simply be {{git am .circleci/high_resource.patch}}?
As discussed offline, we should probably give a heads up to the mailing list
(especially the fact that you now need to enable 'build processing') to get
this to work. Waiting until 2.1 config is out of 'preview' mode might also be
good?
> CircleCI workflow improvements and Java 11 support
> --------------------------------------------------
>
> Key: CASSANDRA-14806
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14806
> Project: Cassandra
> Issue Type: Improvement
> Components: Build, Testing
> Reporter: Stefan Podkowinski
> Assignee: Stefan Podkowinski
> Priority: Major
>
> The current CircleCI config could use some cleanup and improvements. First of
> all, the config has been made more modular by using the new CircleCI 2.1
> executors and command elements. Based on CASSANDRA-14713, there's now also a
> Java 11 executor that will allow running tests under Java 11. The {{build}}
> step will be done using Java 11 in all cases, so we can catch any regressions
> for that and also test the Java 11 multi-jar artifact during dtests, that
> we'd also create during the release process.
> The job workflow has now also been changed to make use of the [manual job
> approval|https://circleci.com/docs/2.0/workflows/#holding-a-workflow-for-a-manual-approval]
> feature, which now allows running dtest jobs only on request and not
> automatically with every commit. The Java8 unit tests still do, but that
> could also be easily changed if needed. See [example
> workflow|https://circleci.com/workflow-run/be25579d-3cbb-4258-9e19-b1f571873850]
> with start_ jobs being triggers needed manual approval for starting the
> actual jobs.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
