[
https://issues.apache.org/jira/browse/CASSANDRA-14806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16665082#comment-16665082
]
Marcus Eriksson commented on CASSANDRA-14806:
---------------------------------------------
bq. by committing the proposed changes as config-2_1.yml, run it through circle
config process and commit the output as config.yml?
yeah makes sense - this also makes sure we only commit a valid config. A bit of
weirdness though, the generated conf you committed has escaped {{/}}s in the
comments, mine doesn't, so I get a big diff by just regenerating the committed
config-2_1.yml (I guess circleci cli version difference or something? Mine is
0.1.3257+b197d90)
bq. work automatically using git commit hooks.
yes, this could be a nice feature, personally though I would probably prefer
just having a small script that does it for me, like
{{.circleci/activate_high_resource.sh}} mostly to avoid regenerating the config
file on every commit (we could probably add a check that only regenerates the
config if the modification time config-2_1.yml is newer than the one on
config.yml).
> CircleCI workflow improvements and Java 11 support
> --------------------------------------------------
>
> Key: CASSANDRA-14806
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14806
> Project: Cassandra
> Issue Type: Improvement
> Components: Build, Testing
> Reporter: Stefan Podkowinski
> Assignee: Stefan Podkowinski
> Priority: Major
>
> The current CircleCI config could use some cleanup and improvements. First of
> all, the config has been made more modular by using the new CircleCI 2.1
> executors and command elements. Based on CASSANDRA-14713, there's now also a
> Java 11 executor that will allow running tests under Java 11. The {{build}}
> step will be done using Java 11 in all cases, so we can catch any regressions
> for that and also test the Java 11 multi-jar artifact during dtests, that
> we'd also create during the release process.
> The job workflow has now also been changed to make use of the [manual job
> approval|https://circleci.com/docs/2.0/workflows/#holding-a-workflow-for-a-manual-approval]
> feature, which now allows running dtest jobs only on request and not
> automatically with every commit. The Java8 unit tests still do, but that
> could also be easily changed if needed. See [example
> workflow|https://circleci.com/workflow-run/be25579d-3cbb-4258-9e19-b1f571873850]
> with start_ jobs being triggers needed manual approval for starting the
> actual jobs.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
