[
https://issues.apache.org/jira/browse/CASSANDRA-14829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16692356#comment-16692356
]
Georg Dietrich commented on CASSANDRA-14829:
--------------------------------------------
Hi [~djoshi3], thanks for looking this over. Maybe I could write a dtest for
this, any maybe not?
* The readme of [cassandra-dtest|https://github.com/apache/cassandra-dtest]
explains how to get the dependencies on Linux and Mac, but the test will be
needed for Windows, so I'll first have to get dtests running there...
* In cassandra-dtest it says "test functionality that requires multiple
Cassandra instances". For my addition to stop-server.bat, a single Cassandra
instance would be enough. Is dtest the right place to write that test?
* When the above two things are settled, I would probably go along the lines
ofÂ
[https://github.com/apache/cassandra-dtest/blob/master/token_generator_test.py,]
where token-generator.bat is called on Windows... - so if I get the tests to
run on Windows, and dtest is the right place, yes, probably I can manage :)
I'll give it a try. Do you have helpful advice (e.g. pointers to resorces / how
to pages)?
> Make stop-server.bat wait for Cassandra to terminate
> ----------------------------------------------------
>
> Key: CASSANDRA-14829
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14829
> Project: Cassandra
> Issue Type: Improvement
> Components: Packaging
> Environment: Windows 10
> Reporter: Georg Dietrich
> Assignee: Georg Dietrich
> Priority: Minor
> Labels: easyfix, windows
> Fix For: 3.11.x, 4.x, 4.0.x
>
>
> While administering a single node Cassandra on Windows, I noticed that the
> stop-server.bat script returns before the cassandra process has actually
> terminated. For use cases like creating a script "shut down & create backup
> of data directory without having to worry about open files, then restart", it
> would be good to make stop-server.bat wait for Cassandra to terminate.
> All that is needed for that is to change in
> apache-cassandra-3.11.3\bin\stop-server.bat "start /B powershell /file ..."
> to "start /WAIT /B powershell /file ..." (additional /WAIT parameter).
> Does this sound reasonable?
> Here is the pull request: https://github.com/apache/cassandra/pull/287
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
