[
https://issues.apache.org/jira/browse/CASSANDRA-14919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16709312#comment-16709312
]
Benedict commented on CASSANDRA-14919:
--------------------------------------
I'm largely +1 the changes, but I wonder if we should be inserting some
assertions around our expectations here.
For instance,
[here|https://github.com/beobal/cassandra/commit/b8bb748dca93deeae7c50319ab0634f599fedea9#diff-f53ee75d79fb30b497f6d1584d51d7d3R2429],
[here|https://github.com/beobal/cassandra/commit/b8bb748dca93deeae7c50319ab0634f599fedea9#diff-861bc950c82973fb8f97f179e35be7f3R1586]
and
[here|https://github.com/beobal/cassandra/commit/b8bb748dca93deeae7c50319ab0634f599fedea9#diff-f53ee75d79fb30b497f6d1584d51d7d3R374]
at least we pretty much require that there be no column name in the payload?
If this is somehow present, something looks likely to have gone awry, since we
are discarding it and have nothing in place to suggest this is OK (unlike
[here|https://github.com/beobal/cassandra/commit/b8bb748dca93deeae7c50319ab0634f599fedea9#diff-861bc950c82973fb8f97f179e35be7f3R1093])?
I'm also honestly not certain what the correct behaviour
[here|https://github.com/beobal/cassandra/commit/b8bb748dca93deeae7c50319ab0634f599fedea9#diff-f53ee75d79fb30b497f6d1584d51d7d3R1245]
is. Presumably for thrift schemas, it is impossible to receive a collection
name. However I'm very out-of-touch with the compatibility mechanisms for
accessing CQL via thrift. Can we legitimately receive a collection RT? I
doubt it, but I cannot be sure.
> Regression in paging queries in mixed version clusters
> -------------------------------------------------------
>
> Key: CASSANDRA-14919
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14919
> Project: Cassandra
> Issue Type: Bug
> Components: CQL
> Reporter: Sam Tunnicliffe
> Assignee: Sam Tunnicliffe
> Priority: Critical
> Fix For: 3.0.x, 3.11.x
>
>
> The changes to handling legacy bounds in
> CASSANDRA-14568/CASSANDRA-14749/CASSANDRA-14912 break paging queries where
> the coordinator is a legacy node and the replica is an upgraded node.
> The long-held assumption made by {{LegacyLayout::decodeBound}} that "There
> can be more components than the clustering size only in the case this is the
> bound of a collection range tombstone." is not true as serialized paged read
> commands may also include these type of bounds in their {{SliceQueryFilter}}.
> The additional checks the more recent tickets add cause such queries to error
> when processed by a 3.0 replica.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
