Jason Brown commented on CASSANDRA-14395:

I've taken a decent look through [~djoshi3]'s first patch, and on the whole, I 
think this is a good first step for this project. I'm not digging too far into 
nit picking at this early stage as I feel it's more important to make forward 
progress overall rather than get tripped up over minor points.

general comments:

- I'm passing over the gradle scripts for now, in lieu of reviewing everything 
else first
- do we need a lib directly with checked in jars, esp with a gradle/mvn style 
build files that pulls jars from mavenCentral?
- need a script to run the app from the command line :) I was able to use 
\{{gradlew run}} to see it work.

code comments
- Configuration - let's add comments to make it easier to distinguish between 
\{{getCassandraPort}} and \{{getPort}}; maybe update the method names, as well. 
I needed to read the \{{MainModule::configuration()}} to figure what each 
method acttually represented.
- in general, I think we want to execute scheduled tasks with 
\{{scheduleWithFixedDelay()}} rather than \{{scheduleAtFixedRate()}}. This way 
tasks don't end up piling up on top of each other if one takes a looong time to 
- there a couple of nit picky things where an instance's final fields are in 
caps, like a constant. trivial at this point.

The only thing I'm not entirely thrilled with is how each URL/handler will need 
to be explicitly wired into the \{{router}} in 
\{{CassandraSidecarDaemon::start()}}. I'm not sure if there's further guice 
magick that can mitigate this. However, I don't feel this is a huge problem for 
the usefulness project as a whole, nor do I think we need to tackle it in the 
early stages or anytime soon.

Looking forward to more activity on this ticket. 

> C* Management process
> ---------------------
>                 Key: CASSANDRA-14395
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-14395
>             Project: Cassandra
>          Issue Type: New Feature
>            Reporter: Dinesh Joshi
>            Assignee: Dinesh Joshi
>            Priority: Major
>         Attachments: Looking towards an Official Cassandra Sidecar - 
> Netflix.pdf
> I would like to propose amending Cassandra's architecture to include a 
> management process. The detailed description is here: 
> https://docs.google.com/document/d/1UV9pE81NaIUF3g4L1wxq09nT11AkSQcMijgLFwGsY3s/edit
> I'd like to propose seeding this with a few simple use-cases such as Health 
> Checks, Bulk Commands with a simple REST API interface. 

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

Reply via email to