[ 
https://issues.apache.org/jira/browse/CASSANDRA-15007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16766898#comment-16766898
 ] 

Dinesh Joshi commented on CASSANDRA-15007:
------------------------------------------

Nevermind, looking at it more deeply, I noticed this is a recent regression. We 
already validate options and throw a meaningful message in 3.x. If you notice 
there is a method called {{validateOptions}} that does exactly what you tried 
doing in the constructor. It looks like this broke on trunk. So now 
{{SimpleStrategy}} creation fails with an exception before we have a chance to 
validate the options.

I have fixed the regression and added a test to avoid future regressions.

||trunk||
|[branch|https://github.com/dineshjoshi/cassandra/tree/15007-trunk]|
|[utests|https://circleci.com/gh/dineshjoshi/workflows/cassandra/tree/15007-trunk]|

> Incorrect rf validation in SimpleStrategy
> -----------------------------------------
>
>                 Key: CASSANDRA-15007
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-15007
>             Project: Cassandra
>          Issue Type: Bug
>          Components: CQL/Semantics
>            Reporter: Michael
>            Assignee: Michael
>            Priority: Minor
>             Fix For: 4.x
>
>         Attachments: 15007.patch
>
>
> Getting uninformative ConfigurationException when trying to create a keyspace 
> with SimpleStrategy and no replication factor.
> {{cqlsh> create keyspace test with replication = \{'class': 
> 'SimpleStrategy'};}}
> {{ConfigurationException:}}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

Reply via email to