[ 
https://issues.apache.org/jira/browse/CASSANDRA-15007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16767004#comment-16767004
 ] 

Michael commented on CASSANDRA-15007:
-------------------------------------

Thanks [~djoshi3] for looking into this. You are right, validation broke on 
trunk, and {{validateOptions}} now is never called if constructor throws an 
exception.

I compared {{SimpleStrategy.java}} and {{NetworkTopologyStrategy.java}} and I 
saw that in the latter case validation code is duplicated both in constructor 
and {{validateOptions}} method. So I think its fine to do the same for 
SimpleStrategy.

> Incorrect rf validation in SimpleStrategy
> -----------------------------------------
>
>                 Key: CASSANDRA-15007
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-15007
>             Project: Cassandra
>          Issue Type: Bug
>          Components: CQL/Semantics
>            Reporter: Michael
>            Assignee: Dinesh Joshi
>            Priority: Minor
>             Fix For: 4.x
>
>         Attachments: 15007.patch
>
>
> Getting uninformative ConfigurationException when trying to create a keyspace 
> with SimpleStrategy and no replication factor.
> {{cqlsh> create keyspace test with replication = \{'class': 
> 'SimpleStrategy'};}}
> {{ConfigurationException:}}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

Reply via email to