[
https://issues.apache.org/jira/browse/CASSANDRA-15092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16821016#comment-16821016
]
Brandon Williams commented on CASSANDRA-15092:
----------------------------------------------
Looks good to me, but I would collapse the imports. Also when the return code
isn't 200 it would be useful to print what it was. Finally, I would just
mention taking extra caution in how you parse the dc/rack names, since the
ec2mrs snitch had to get inventive when Amazon changed something that broke it,
and once you emit a DC name there's really no going back.
> Add a new Snitch for Alibaba Cloud Platform
> -------------------------------------------
>
> Key: CASSANDRA-15092
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15092
> Project: Cassandra
> Issue Type: New Feature
> Components: Legacy/Core, Local/Config
> Reporter: maxwellguo
> Assignee: maxwellguo
> Priority: Normal
>
> Add snitch for Alibaba cloud platform, for we have saw cloud platform snitch
> for aws and google cloud ,for we can ge alibaba ecs (Elastic Compute Service)
> meta data from here :
> https://help.aliyun.com/document_detail/108460.html?spm=a2c4g.11186623.6.675.36684f8bLQrIMY
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
