[
https://issues.apache.org/jira/browse/CASSANDRA-15105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16844283#comment-16844283
]
Sumanth Pasupuleti edited comment on CASSANDRA-15105 at 5/20/19 10:55 PM:
--------------------------------------------------------------------------
I've reviewed the patch. LGTM w.r.t. fix for {{AuditLoggerTest}} class. As I
ran UTs multiple times with this patch, I noticed
{{testExcludeSystemKeyspaces}} still
[fails|https://circleci.com/gh/sumanth-pasupuleti/cassandra/508#tests/containers/14]
due to events collected in {{InMemoryAuditLogger}}.
I did a scrub across the UTs to make sure we disable audit logger each time we
enable, and consequently made a change to {{StorageServiceServerTest}} on top
of [~eperott]'s patch. From my several (10)
[runs|https://circleci.com/gh/sumanth-pasupuleti/workflows/cassandra/tree/15105_trunk_UT]
of UTs, AuditLogger tests have been passing.
[Patch|https://github.com/apache/cassandra/pull/323]
[Passing
Tests|https://circleci.com/workflow-run/7a96f12c-c695-4ca8-8bf6-36108bdaa75c]
was (Author: sumanth.pasupuleti):
I've reviewed the patch. LGTM w.r.t. fix for {{AuditLoggerTest}} class. As I
ran UTs multiple times with this patch, I noticed
{{testExcludeSystemKeyspaces}} still
[fails|https://circleci.com/gh/sumanth-pasupuleti/cassandra/508#tests/containers/14]
due to events collected in {{InMemoryAuditLogger}}.
I did a scrub across the UTs to make sure we disable audit logger each time we
enable, and consequently made a change to {{StorageServiceServerTest}} on top
of [~eperott]'s patch. From my several (10) runs of UTs, AuditLogger tests have
been passing.
[Patch|https://github.com/apache/cassandra/pull/323]
[Passing
Tests|https://circleci.com/workflow-run/7a96f12c-c695-4ca8-8bf6-36108bdaa75c]
> Flaky unit test AuditLoggerTest
> -------------------------------
>
> Key: CASSANDRA-15105
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15105
> Project: Cassandra
> Issue Type: Bug
> Components: Legacy/CQL
> Reporter: Per Otterström
> Assignee: Per Otterström
> Priority: Normal
> Fix For: 4.0
>
>
> Depending on execution order some tests will fail in the AuditLoggerTest
> class. Any test case that happens to execute after
> testExcludeSystemKeyspaces() will typically fail.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
