[
https://issues.apache.org/jira/browse/CASSANDRA-15105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16853622#comment-16853622
]
Vinay Chella edited comment on CASSANDRA-15105 at 6/1/19 8:06 AM:
------------------------------------------------------------------
Thanks for the patch [~eperott], [~sumanth.pasupuleti] for review and changes.
We might need to exclude {{system_virtual_schema}} also from
{{AuditLoggerTest::testIncludeSystemKeyspaces()}} and
{{AuditLoggerTest::testExcludeSystemKeyspaces}} methods for future readiness
when and if {{system_virtual_schema}} is also quried from control connection,
this also keeps us in sync with defaults behavior. I pushed this change in my
brnach
[here|https://github.com/vinaykumarchella/cassandra/commits/CASSANDRA-15105]. I
will commit this as soon
[tests|https://circleci.com/gh/vinaykumarchella/workflows/cassandra/tree/CASSANDRA-15105]
pass.
was (Author: vinaykumarcse):
Thanks for the patch [~eperott], [~sumanth.pasupuleti] and review.
We might need to exclude {{system_virtual_schema}} also from
{{AuditLoggerTest::testIncludeSystemKeyspaces()}} and
{{AuditLoggerTest::testExcludeSystemKeyspaces}} methods for future readiness
when and if {{system_virtual_schema}} is also quried from control connection,
this also keeps us in sync with defaults behavior. I pushed this change in my
brnach
[here|https://github.com/vinaykumarchella/cassandra/commits/CASSANDRA-15105]. I
will commit this as soon
[tests|https://circleci.com/gh/vinaykumarchella/workflows/cassandra/tree/CASSANDRA-15105]
pass.
> Flaky unit test AuditLoggerTest
> -------------------------------
>
> Key: CASSANDRA-15105
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15105
> Project: Cassandra
> Issue Type: Bug
> Components: Legacy/CQL
> Reporter: Per Otterström
> Assignee: Per Otterström
> Priority: Normal
> Fix For: 4.0
>
>
> Depending on execution order some tests will fail in the AuditLoggerTest
> class. Any test case that happens to execute after
> testExcludeSystemKeyspaces() will typically fail.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
