Chris Lohfink commented on CASSANDRA-14781:

Thanks for the update! A few more things things:

* Lets make this work for 4.0 first, I am not sure about backporting it to 3.11 
or 3.0 at this point
* Can you move the {{limit}} up to a constant? Be great if that was something 
we can override too in yaml/jmx override incase need to to see more than 10 and 
accept risk but that can come later if dont want to include it in this patch. 
* If limited, can you make sure to show largest keys first instead of just 
taking first off the updates.
* If we have metadata and the key, instead of doing a toString on the decorated 
key which gives a large hex dump, you can use 
{{partitionKeyType.getString(keybytes)}} to get the human readable version.

something like (this is untested, just example):
                         .map(upd -> String.format("%s[%s]",
                         .collect(Collectors.joining(", "));

> Log message when mutation passed to CommitLog#add(Mutation) is too large is 
> not descriptive enough
> --------------------------------------------------------------------------------------------------
>                 Key: CASSANDRA-14781
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-14781
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Legacy/Local Write-Read Paths
>            Reporter: Jordan West
>            Assignee: Tom Petracca
>            Priority: Normal
>             Fix For: 3.0.x, 3.11.x, 4.0.x
>         Attachments: CASSANDRA-14781.patch, CASSANDRA-14781_3.0.patch, 
> CASSANDRA-14781_3.11.patch
> When hitting 
> [https://github.com/apache/cassandra/blob/cassandra-3.0/src/java/org/apache/cassandra/db/commitlog/CommitLog.java#L256-L257],
>  the log message produced does not help the operator track down what data is 
> being written. At a minimum the keyspace and cfIds involved would be useful 
> (and are available) – more detail might not be reasonable to include. 

This message was sent by Atlassian Jira

To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

Reply via email to