[
https://issues.apache.org/jira/browse/CASSANDRA-14781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17008622#comment-17008622
]
Venkata Harikrishna Nukala commented on CASSANDRA-14781:
--------------------------------------------------------
[~jrwest] Made a patch with the changes. [~tpetracca] apologies if I am
overtaking you.
Here is the
[patch|https://github.com/nvharikrishna/cassandra/commit/5b3af390ce64860505dfeb3a3549cc9897987771]
and [CI|https://app.circleci.com/jobs/github/nvharikrishna/cassandra/95].
I have a small question though. In
[CommitLog.java|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/db/commitlog/CommitLog.java#L274],
it considers commit log entry overhead with mutation size to compare with max
mutation size. Shouldn't it consider only the mutation size? I made changes to
be compatible with overhead (I can change based on your comments).
{{SizeHolder}} introduced in this patch can be used in {{Message}} as well. I
can make this change too if it is okay to mixup.
> Log message when mutation passed to CommitLog#add(Mutation) is too large is
> not descriptive enough
> --------------------------------------------------------------------------------------------------
>
> Key: CASSANDRA-14781
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14781
> Project: Cassandra
> Issue Type: Bug
> Components: Consistency/Hints, Local/Commit Log, Messaging/Client
> Reporter: Jordan West
> Assignee: Tom Petracca
> Priority: Normal
> Labels: protocolv5
> Fix For: 4.0-beta
>
> Attachments: CASSANDRA-14781.patch, CASSANDRA-14781_3.0.patch,
> CASSANDRA-14781_3.11.patch
>
>
> When hitting
> [https://github.com/apache/cassandra/blob/cassandra-3.0/src/java/org/apache/cassandra/db/commitlog/CommitLog.java#L256-L257],
> the log message produced does not help the operator track down what data is
> being written. At a minimum the keyspace and cfIds involved would be useful
> (and are available) – more detail might not be reasonable to include.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
