David Capwell commented on CASSANDRA-15507:

The only thing I have thought of to solve this is to make the selection 
pluggable (rather not mutate CQL for this) so dtest could just override the 
implementation.  The main reason I didn't go this route was in a attempt to try 
to make this less specific to a version; so the cost is a potentially failing 
test in the future...

> Test 
> org.apache.cassandra.distributed.test.DistributedReadWritePathTest#failingReadRepairTest
>  does not test a failing read repair and should be updated to actually 
> trigger a failed read repair
> ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>                 Key: CASSANDRA-15507
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-15507
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Test/unit
>            Reporter: David Capwell
>            Assignee: David Capwell
>            Priority: Normal
>              Labels: pull-request-available
>          Time Spent: 20m
>  Remaining Estimate: 0h
> The test 
> org.apache.cassandra.distributed.test.DistributedReadWritePathTest#failingReadRepairTest
>  makes a few assumptions which are not valid at the moment.
> 1) the write to node 1 and 2 have the same digest (they don’t, this is caused 
> by the timestamp being different)
> 2) node 3 will participate with the read; it won’t give the fact that 
> org.apache.cassandra.locator.ReplicaPlans#contactForRead will speculate the 
> first 2 nodes always, so node 3 won’t get involved with the repair
> 3) node 3 will attempt to get repaired (it won’t because its never looked at)

This message was sent by Atlassian Jira

To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

Reply via email to