[
https://issues.apache.org/jira/browse/CASSANDRA-15507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17018041#comment-17018041
]
Alex Petrov commented on CASSANDRA-15507:
-----------------------------------------
You're right; the way it is implemented now is not quite right.
Patch looks good to me, +1.
Committed to trunk with
[815c397f4876aae9ed2ae5a9578c5ec7087643ab|https://github.com/apache/cassandra/commit/815c397f4876aae9ed2ae5a9578c5ec7087643ab]
> Test
> org.apache.cassandra.distributed.test.DistributedReadWritePathTest#failingReadRepairTest
> does not test a failing read repair and should be updated to actually
> trigger a failed read repair
> ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: CASSANDRA-15507
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15507
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
> Reporter: David Capwell
> Assignee: David Capwell
> Priority: Normal
> Labels: pull-request-available
> Time Spent: 20m
> Remaining Estimate: 0h
>
> The test
> org.apache.cassandra.distributed.test.DistributedReadWritePathTest#failingReadRepairTest
> makes a few assumptions which are not valid at the moment.
> 1) the write to node 1 and 2 have the same digest (they don’t, this is caused
> by the timestamp being different)
> 2) node 3 will participate with the read; it won’t give the fact that
> org.apache.cassandra.locator.ReplicaPlans#contactForRead will speculate the
> first 2 nodes always, so node 3 won’t get involved with the repair
> 3) node 3 will attempt to get repaired (it won’t because its never looked at)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
