[ 
https://issues.apache.org/jira/browse/CASSANDRA-15512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17044486#comment-17044486
 ] 

Benedict Elliott Smith commented on CASSANDRA-15512:
----------------------------------------------------

So, first off I want to say this is all super awesome.  I haven't had a chance 
to review it (or even more than glance at it), but I _love_ what you've built 
on top here.

I have only one preliminary suggestion: have you considered Hilbert curves (or 
other space-filling curves), instead of declaring your own points you linearly 
interpolate to combine?  This _might_ seem to be a little easier to reason 
about for test authors, since they don't need to think about what combinations 
they want (just pick a number of divisions of the curve), and has the potential 
to make the tooling you've produced totally transparent to all future 
benchmarks that might utilise this approach.

> Add compaction-related JMH tests
> --------------------------------
>
>                 Key: CASSANDRA-15512
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-15512
>             Project: Cassandra
>          Issue Type: Sub-task
>          Components: Local/Compaction
>            Reporter: Benedict Elliott Smith
>            Assignee: Benedict Elliott Smith
>            Priority: Normal
>
> Following up CASSANDRA-15388, we should introduce some isolated JMH tests 
> covering at least the compaction merge path and partition deserialization, 
> covering a wide range of partition shapes and characteristics.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

Reply via email to