[
https://issues.apache.org/jira/browse/CASSANDRA-15570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17044702#comment-17044702
]
Jon Haddad commented on CASSANDRA-15570:
----------------------------------------
LGTM, +1. I think having the p not only is more convenient with regard to the
quotes but also more obvious in that it's labeling a percentile.
{noformat}
keyspace_name | table_name | count | max_ms |
p50th_ms | p99th_ms | per_second
--------------------+--------------------------------+-------+---------+----------+----------+------------
system | IndexInfo | 0 | 0 |
0 | 0 | 0
system | available_ranges | 0 | 0 |
0 | 0 | 0
system | available_ranges_v2 | 0 | 0 |
0 | 0 | 0
system | batches | 0 | 0 |
0 | 0 | 0
system | built_views | 0 | 0 |
0 | 0 | 0
system | compaction_history | 0 | 0 |
0 | 0 | 0
system | local | 28 | 107.965 |
1.132 | 107.965 | 4.407
{noformat}
Thanks [~cnlwsu]!
> Change name of table metrics virtual table percentile columns
> -------------------------------------------------------------
>
> Key: CASSANDRA-15570
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15570
> Project: Cassandra
> Issue Type: Improvement
> Components: Feature/Virtual Tables
> Reporter: Chris Lohfink
> Assignee: Chris Lohfink
> Priority: Low
> Labels: pull-request-available
> Time Spent: 10m
> Remaining Estimate: 0h
>
> The column names {{50th}} and {{90th}} are difficult to query as a selector
> or in aggregation functions since our parser expects a letter for initial
> char. It currently requires quoting like:
> {code:sql}
> SELECT table_name, "50th_ms", "99th_ms" FROM system_views.local_read_latency
> {code}
> Which is kinda difficult and non obvious, the error we give when not quoted
> also isnt that helpful. Since it is percentile a simple thing is to just ad a
> p infront:
> {code:sql}
> SELECT table_name, p50th_ms, p99th_ms FROM system_views.local_read_latency
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
