[
https://issues.apache.org/jira/browse/CASSANDRA-15564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17047140#comment-17047140
]
David Capwell commented on CASSANDRA-15564:
-------------------------------------------
[~bdeggleston] all feedback addressed
[Drop Either and refactor run to be smaller
methods|https://github.com/apache/cassandra/pull/446/commits/e7b16f0264b890bbc872fb50ec43f31833d4cced]
[Moved Retry and added
docs|https://github.com/apache/cassandra/pull/446/commits/b93bb170bbad0c1bfcdfb3eafd01cf968aee92d5]
[Remove the assert and removed all new final variables, I left the variables
where were not marked final by
me|https://github.com/apache/cassandra/pull/446/commits/fa75965331ae0e3901eaad4f927f6cadcde252bc]
> Refactor repair coordinator so errors are consistent
> ----------------------------------------------------
>
> Key: CASSANDRA-15564
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15564
> Project: Cassandra
> Issue Type: Sub-task
> Components: Consistency/Repair
> Reporter: David Capwell
> Assignee: David Capwell
> Priority: Normal
> Labels: pull-request-available
> Time Spent: 10h 50m
> Remaining Estimate: 0h
>
> This is to split the change in CASSANDRA-15399 so the refactor is isolated
> out.
> Currently the repair coordinator special cases the exit cases at each call
> site; this makes it so that errors can be inconsistent and there are cases
> where proper complete isn't done (proper notifications, and forgetting to
> update ActiveRepairService).
> [Circle
> CI|https://circleci.com/gh/dcapwell/cassandra/tree/bug%2FrepairCoordinatorJmxConsistency]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
