[
https://issues.apache.org/jira/browse/CASSANDRA-15564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17050748#comment-17050748
]
David Capwell commented on CASSANDRA-15564:
-------------------------------------------
bq. tryStoreParentRepairStart - the naming convention with methods like these
would be maybeStoreParentRepairStart, try implies error handling, which isn't
really applicable here
matches org.apache.cassandra.utils.memory.BufferPool#tryGet (returns null) and
org.apache.cassandra.io.sstable.SSTable#tryComponentFromFilename (returns null,
but only if throws). Seems like we are not too consistent as a project but we
should at least be for a sub-module; I see repair favors maybe
(org.apache.cassandra.repair.consistent.LocalSessions#maybeSetRepairing); made
the change.
Pushed changed for most comments; [~bdeggleston] feedback applied
[here|https://github.com/dcapwell/cassandra/commit/c24622240f8e827a77753daa3ec626afbd383c74]
The only change not made was "response time" vs "service time"
> Refactor repair coordinator so errors are consistent
> ----------------------------------------------------
>
> Key: CASSANDRA-15564
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15564
> Project: Cassandra
> Issue Type: Sub-task
> Components: Consistency/Repair
> Reporter: David Capwell
> Assignee: David Capwell
> Priority: Normal
> Labels: pull-request-available
> Time Spent: 11h 10m
> Remaining Estimate: 0h
>
> This is to split the change in CASSANDRA-15399 so the refactor is isolated
> out.
> Currently the repair coordinator special cases the exit cases at each call
> site; this makes it so that errors can be inconsistent and there are cases
> where proper complete isn't done (proper notifications, and forgetting to
> update ActiveRepairService).
> [Circle
> CI|https://circleci.com/gh/dcapwell/cassandra/tree/bug%2FrepairCoordinatorJmxConsistency]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
