[ 
https://issues.apache.org/jira/browse/CASSANDRA-15557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17054908#comment-17054908
 ] 

Ryan Svihla commented on CASSANDRA-15557:
-----------------------------------------

So looking at the alter schema logic more:
[https://github.com/apache/cassandra/blob/08b2192da0eb6deddcd8f79cd180d069442223ae/src/java/org/apache/cassandra/cql3/statements/schema/AlterTableStatement.java#L398]

and 
[https://github.com/apache/cassandra/blob/08b2192da0eb6deddcd8f79cd180d069442223ae/src/java/org/apache/cassandra/cql3/statements/schema/AlterTableStatement.java#L411-L426]

it does seem (naively) reasonable to have it using the ClientState's 
getTimestamp() method in the AlterTableStatement since the ClientState is 
already there, but I'm sure I'm missing lots of background. 

Will wait for more experience people to weigh in.

> Fix flaky test org.apache.cassandra.cql3.validation.operations.AlterTest 
> testDropListAndAddListWithSameName
> -----------------------------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-15557
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-15557
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Test/unit
>            Reporter: David Capwell
>            Assignee: Ryan Svihla
>            Priority: Normal
>             Fix For: 4.0-alpha
>
>
> https://app.circleci.com/jobs/github/dcapwell/cassandra/482/tests
> {code}
> junit.framework.AssertionFailedError: Invalid value for row 0 column 2 
> (mycollection of type list<text>), expected <null> but got <[first element]>
>       at org.apache.cassandra.cql3.CQLTester.assertRows(CQLTester.java:1070)
>       at 
> org.apache.cassandra.cql3.validation.operations.AlterTest.testDropListAndAddListWithSameName(AlterTest.java:91)
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to