Ekaterina Dimitrova commented on CASSANDRA-15650:

Apologize, started this only in the afternoon, got some troubles earlier.

Thanks for the additional explanation, that helped!

As we talked on slack, for some weird reason the shell script is failing to run.
But with the simple loop of the ant command, the test runs properly. (putting 
this here for the record in case anyone else decides to play with this one and 
experience my issues)
Unfortunately, it never failed on my Mac, also on ubuntu vm.
But I checked the logic and in general it looks good to me. 

Based on the JUnit documentation I was tempted to say you are actually 
implementing assertTimeout for a supplier and not assertTimeoutPreemptively 
which is for executables.
But I saw you actually adjusted the original implementation and from that 
perspective it is accurate.

>From the circle logs I saw the way the threads are locking as there is another 
>test failing. It looks really lengthy. I wanna look at it better tomorrow 
>morning with a refreshed mind and implement a couple of other tests before 
>voting for the patch. Thanks!

> Fix flaky test 
> org.apache.cassandra.distributed.test.*RepairCoordinatorFastTest
> -------------------------------------------------------------------------------
>                 Key: CASSANDRA-15650
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-15650
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Test/dtest
>            Reporter: David Capwell
>            Assignee: David Capwell
>            Priority: Normal
>              Labels: pull-request-available
>             Fix For: 4.0-alpha
>          Time Spent: 10m
>  Remaining Estimate: 0h
> Test failure: 
> https://app.circleci.com/pipelines/github/dcapwell/cassandra/177/workflows/3dff37a5-9bf4-40e2-8d5b-f127b416dc79/jobs/862
> {code}
> [junit-timeout] Testcase: 
> onlyCoordinator[SEQUENTIAL/true](org.apache.cassandra.distributed.test.FullRepairCoordinatorFastTest):
>       FAILED
> [junit-timeout] nodetool command repair was successful but not expected to 
> be. Actual: 0
> [junit-timeout] junit.framework.AssertionFailedError: nodetool command repair 
> was successful but not expected to be. Actual: 0
> [junit-timeout]       at 
> org.apache.cassandra.distributed.api.NodeToolResult$Asserts.failure(NodeToolResult.java:76)
> [junit-timeout]       at 
> org.apache.cassandra.distributed.test.RepairCoordinatorFast.onlyCoordinator(RepairCoordinatorFast.java:255)
> [junit-timeout]       at 
> java.util.concurrent.FutureTask.run(FutureTask.java:266)
> [junit-timeout]       at java.lang.Thread.run(Thread.java:748)
> {code}
> [Circle CI 
> LOWER|https://circleci.com/gh/dcapwell/cassandra/tree/bug%2FrepairCoordinatorTestFlaky]

This message was sent by Atlassian Jira

To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

Reply via email to