[
https://issues.apache.org/jira/browse/CASSANDRA-15630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17067789#comment-17067789
]
Yifan Cai commented on CASSANDRA-15630:
---------------------------------------
CI passed. Link:
https://app.circleci.com/pipelines/github/yifan-c/cassandra/59/workflows/9b1dee87-f930-4729-a577-71da5fc9660c/jobs/282
However, I do not think it is very representative. (There are other flaky tests
in the code base, a green run is more because of luck).
In addition, I made a docker container that caps CPUs to 2 to run the
{{ConnectionTest}} repeatedly until failure. [^CASS-15630-TEST-DOCKER.zip]
It applies another flaky test fixing patch that has not been merged yet before
running the repeating test. On my local, the test passes for dozen times.
Regarding the comment, it is probably better to use {{spinAssertEquals}}
explicitly. If you strongly prefer to use testAndFailCheck, I am cool with it.
Thanks all for reviewing!
> Fix flakey testSerializeError - org.apache.cassandra.net.ConnectionTest
> -----------------------------------------------------------------------
>
> Key: CASSANDRA-15630
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15630
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
> Reporter: Yifan Cai
> Assignee: Yifan Cai
> Priority: Normal
> Labels: pull-request-available
> Fix For: 4.0-beta
>
> Attachments: CASS-15630-TEST-DOCKER.zip
>
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> The test fails sometimes with the following error message and trace.
> {code:java}
> processed count values don't match expected:<90> but was:<89>
> junit.framework.AssertionFailedError: processed count values don't match
> expected:<90> but was:<89>
> at
> org.apache.cassandra.net.ConnectionUtils$InboundCountChecker.doCheck(ConnectionUtils.java:217)
> at
> org.apache.cassandra.net.ConnectionUtils$InboundCountChecker.check(ConnectionUtils.java:200)
> at
> org.apache.cassandra.net.ConnectionTest.lambda$testSerializeError$24(ConnectionTest.java:494)
> at
> org.apache.cassandra.net.ConnectionTest.lambda$doTest$8(ConnectionTest.java:240)
> at
> org.apache.cassandra.net.ConnectionTest.doTestManual(ConnectionTest.java:260)
> at org.apache.cassandra.net.ConnectionTest.doTest(ConnectionTest.java:238)
> at org.apache.cassandra.net.ConnectionTest.test(ConnectionTest.java:227)
> at
> org.apache.cassandra.net.ConnectionTest.testSerializeError(ConnectionTest.java:435){code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
