[
https://issues.apache.org/jira/browse/CASSANDRA-15783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17100449#comment-17100449
]
ZhaoYang edited comment on CASSANDRA-15783 at 5/6/20, 4:46 AM:
---------------------------------------------------------------
Error trace:
{code:java}
=================================== FAILURES ===================================
_________ TestTransientReplication.test_optimized_primary_range_repair _________
self = <transient_replication_test.TestTransientReplication object at
0x7ffbe11a9978>
@pytest.mark.no_vnodes
def test_optimized_primary_range_repair(self):
""" optimized primary range incremental repair from full replica should
remove data on node3 """
self._test_speculative_write_repair_cycle(primary_range=True,
optimized_repair=True,
repair_coordinator=self.node1,
> expect_node3_data=False)
transient_replication_test.py:463:
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
transient_replication_test.py:435: in _test_speculative_write_repair_cycle
self.assert_has_sstables(self.node2, compact=True)
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
self = <transient_replication_test.TestTransientReplication object at
0x7ffbe11a9978>
node = <ccmlib.node.Node object at 0x7ffadec56ac8>, flush = False
compact = True
def assert_has_sstables(self, node, flush=False, compact=False):
if flush:
node.flush()
if compact:
node.nodetool(' '.join(['compact', self.keyspace, self.table]))
sstables = node.get_sstables(self.keyspace, self.table)
> assert sstables
E assert []
{code}
copying my comment from 15657:
{quote}This patch allows ZCS for size-tiered compaction which is used by the
test and the test log showed that the file is indeed received via ZCS...
{code:java}
INFO [CompactionExecutor:2] 2020-05-06 12:28:10,848
PendingRepairManager.java:446 - Obsoleting transient repaired ssatbles
DEBUG [CompactionExecutor:2] 2020-05-06 12:28:10,852
PendingRepairManager.java:144 - Removing compaction strategy for pending repair
fc89be70-8f51-11ea-8232-f78d8bc3c1f4 on ks.tblINFO [NonPeriodicTasks:1]
2020-05-06 12:28:10,855 SSTable.java:111 - Deleting sstable:
/private/var/folders/w0/m4svxry56h56g_42mx0rwbcr0000gn/T/dtest-9fybyxp7/test/node2/data0/ks/tbl-f26130408f5111ea8232f78d8bc3c1f4/na-1-big
{code}
Transient replica {{PendingRepairManager}} is removing the received file and
it's doing it earlier on ZCS sstable than non-ZCS sstable because ZCS sstable
carries "repairedAt" metadata.
{quote}
[~e.dimitrova] [~djoshi] not sure if it's an expected behavior from transient
replica...
Let me know if there is anything I can help..
was (Author: jasonstack):
Error trace:
{code:java}
=================================== FAILURES ===================================
_________ TestTransientReplication.test_optimized_primary_range_repair _________
self = <transient_replication_test.TestTransientReplication object at
0x7ffbe11a9978>
@pytest.mark.no_vnodes
def test_optimized_primary_range_repair(self):
""" optimized primary range incremental repair from full replica should
remove data on node3 """
self._test_speculative_write_repair_cycle(primary_range=True,
optimized_repair=True,
repair_coordinator=self.node1,
> expect_node3_data=False)
transient_replication_test.py:463:
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
transient_replication_test.py:435: in _test_speculative_write_repair_cycle
self.assert_has_sstables(self.node2, compact=True)
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
self = <transient_replication_test.TestTransientReplication object at
0x7ffbe11a9978>
node = <ccmlib.node.Node object at 0x7ffadec56ac8>, flush = False
compact = True
def assert_has_sstables(self, node, flush=False, compact=False):
if flush:
node.flush()
if compact:
node.nodetool(' '.join(['compact', self.keyspace, self.table]))
sstables = node.get_sstables(self.keyspace, self.table)
> assert sstables
E assert []
{code}
copying my comment from 15657:
{quote}This patch allows ZCS for size-tiered compaction which is used by the
test and the test log showed that the file is indeed received via ZCS...
{code:java}
INFO [CompactionExecutor:2] 2020-05-06 12:28:10,848
PendingRepairManager.java:446 - Obsoleting transient repaired ssatbles
DEBUG [CompactionExecutor:2] 2020-05-06 12:28:10,852
PendingRepairManager.java:144 - Removing compaction strategy for pending repair
fc89be70-8f51-11ea-8232-f78d8bc3c1f4 on ks.tblINFO [NonPeriodicTasks:1]
2020-05-06 12:28:10,855 SSTable.java:111 - Deleting sstable:
/private/var/folders/w0/m4svxry56h56g_42mx0rwbcr0000gn/T/dtest-9fybyxp7/test/node2/data0/ks/tbl-f26130408f5111ea8232f78d8bc3c1f4/na-1-big
{code}
Transient replica \{{PendingRepairManager}} is removing the received file and
it's doing it earlier on ZCS sstable than non-ZCS sstable because ZCS sstable
carries "repairedAt" metadata.
{quote}
Let me know if there is anything I can help
> test_optimized_primary_range_repair -
> transient_replication_test.TestTransientReplication
> -----------------------------------------------------------------------------------------
>
> Key: CASSANDRA-15783
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15783
> Project: Cassandra
> Issue Type: Bug
> Components: Test/dtest
> Reporter: Ekaterina Dimitrova
> Assignee: Ekaterina Dimitrova
> Priority: Normal
> Fix For: 4.0-alpha
>
>
> Dtest failure.
> Example:
> https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/118/workflows/9e57522d-52fa-4d44-88d8-5cec0e87f517/jobs/585/tests
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
