[ 
https://issues.apache.org/jira/browse/CASSANDRA-15685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17101922#comment-17101922
 ] 

David Capwell commented on CASSANDRA-15685:
-------------------------------------------

[~e.dimitrova] I stopped working on it as I lost my time =(.  If you want, feel 
free to pick it up! =D

The current state is that the test requires knowing the result of the previous 
repair which only happens as a JMX notification, which is lossy; if the 
notification is lost, the test fails.

I was planning to append the result to the completion message as we can get 
that via polling, for this reason the test could not use the nodetool API but 
would need to poll directly (which it does today).  I also had a patch a bit 
back to fix nodetool to detect failures in case of JMX loosing the error 
message, this polling would need to do similar (so should probably be a common 
function).

Now, the change to the completion message is better IMO since it also fixes 
this for operators (if the notification is lost you don't know if there was a 
conflict), since polling will also see the latest message and will report it 
correctly. 

For now I will unassigned myself.

> flaky testWithMismatchingPending - 
> org.apache.cassandra.distributed.test.PreviewRepairTest
> ------------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-15685
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-15685
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Test/dtest
>            Reporter: Kevin Gallardo
>            Assignee: David Capwell
>            Priority: Normal
>              Labels: pull-request-available
>             Fix For: 4.0-alpha
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Observed in: 
> https://app.circleci.com/pipelines/github/newkek/cassandra/34/workflows/1c6b157d-13c3-48a9-85fb-9fe8c153256b/jobs/191/tests
> Failure:
> {noformat}
> testWithMismatchingPending - 
> org.apache.cassandra.distributed.test.PreviewRepairTest
> junit.framework.AssertionFailedError
>       at 
> org.apache.cassandra.distributed.test.PreviewRepairTest.testWithMismatchingPending(PreviewRepairTest.java:97)
> {noformat}
> [Circle 
> CI|https://circleci.com/gh/dcapwell/cassandra/tree/bug%2FCASSANDRA-15685]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to