[
https://issues.apache.org/jira/browse/CASSANDRA-15685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17107592#comment-17107592
]
David Capwell commented on CASSANDRA-15685:
-------------------------------------------
*
https://github.com/apache/cassandra/compare/trunk...ekaterinadimitrova2:CASSANDRA-15685#diff-584fc321d5855ec6340e5477d8e7e469R373.
if you make it this far it means await was already signaled, so this should be
a noop
*
https://github.com/apache/cassandra/compare/trunk...ekaterinadimitrova2:CASSANDRA-15685#diff-584fc321d5855ec6340e5477d8e7e469R376
this fixes the failed case, but what about the preview repair notification
getting lost?
The test has two issues
* not see the error, so believe the job was success; you handle this case
* not see the notification, so unable to update wasInconsistent; currently not
handled.
To handle the second case, you would need to update the completion message then
check for that in the test. This is desirable since nodetool has the same
issue, so moving it to complete would mean we always log it.
> flaky testWithMismatchingPending -
> org.apache.cassandra.distributed.test.PreviewRepairTest
> ------------------------------------------------------------------------------------------
>
> Key: CASSANDRA-15685
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15685
> Project: Cassandra
> Issue Type: Bug
> Components: Test/dtest
> Reporter: Kevin Gallardo
> Assignee: Ekaterina Dimitrova
> Priority: Normal
> Labels: pull-request-available
> Fix For: 4.0-alpha
>
> Attachments: log-CASSANDRA-15685.txt, output
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Observed in:
> https://app.circleci.com/pipelines/github/newkek/cassandra/34/workflows/1c6b157d-13c3-48a9-85fb-9fe8c153256b/jobs/191/tests
> Failure:
> {noformat}
> testWithMismatchingPending -
> org.apache.cassandra.distributed.test.PreviewRepairTest
> junit.framework.AssertionFailedError
> at
> org.apache.cassandra.distributed.test.PreviewRepairTest.testWithMismatchingPending(PreviewRepairTest.java:97)
> {noformat}
> [Circle
> CI|https://circleci.com/gh/dcapwell/cassandra/tree/bug%2FCASSANDRA-15685]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
