[
https://issues.apache.org/jira/browse/CASSANDRA-15877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17136198#comment-17136198
]
Kornel Pal commented on CASSANDRA-15877:
----------------------------------------
Thank you [~e.dimitrova], for further improving on the previous change and even
fixing a bug that previously resulted in a flaky unit test.
I've noticed that you added a new NoReplicationTokenAllocatorTest.failed field
with assertions, but it does not seem to be set to true anywhere. Could you
please check whether it is needed.
After the change from random tokens to splits,
TokenAllocatorDiagnostics.randomTokensGenerated does not seem to be used
anymore. Could you please consider removing it, if not needed.
> Followup on CASSANDRA-15600
> ---------------------------
>
> Key: CASSANDRA-15877
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15877
> Project: Cassandra
> Issue Type: Bug
> Components: Feature/Virtual Nodes
> Reporter: Ekaterina Dimitrova
> Assignee: Ekaterina Dimitrova
> Priority: Normal
> Fix For: 4.0, 4.0-alpha
>
>
> As part of CASSANDRA-15600 generateSplits method replaced the
> generateRandomTokens for NoReplicationAwareTokenAllocator. generateSplits
> should be used also in ReplicationAwareTokenAllocator.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
