[
https://issues.apache.org/jira/browse/CASSANDRA-2280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13037826#comment-13037826
]
Sylvain Lebresne commented on CASSANDRA-2280:
---------------------------------------------
* If we're going to put that in 0.8.1 (which we should), we cannot rely on
MessagingService.VERSION_07. We must bump the version for 0.8.0. Turns out
CASSANDRA-2433 already have this problem, so I suggest we introduce a
MS.VERSION_080 and stick to that (as a side note, when that's done, we should
be careful with StreamRequestMessage as it will have a 0.7 and 0.8.0 part, i.e,
we shouldn't blindly s/VERSION_07/VERSION_080 in there).
* In StreamHeader and StreamRequestMessage, Iterables.size() is used. Is there
a reason for that ? Though google collections are probably smart enough to not
do a full iteration to compute the size when possible, in theory we can't
really be sure so I don't see why not use .size() (and use a Collection<>
instead of Iterable in StreamHeader, although see next point).
* Why are we sending the cfs in StreamHeader at all. It's never used and I
don't see why it should (StreamInSession will know what it receive with each
file, no reason why it should know upfront what was the request that initiated
the streaming).
> Request specific column families using StreamIn
> -----------------------------------------------
>
> Key: CASSANDRA-2280
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2280
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Stu Hood
> Assignee: Jonathan Ellis
> Fix For: 0.8.1
>
> Attachments:
> 0001-Allow-specific-column-families-to-be-requested-for-str.txt,
> 0001-Allow-specific-column-families-to-be-requested-for-str.txt, 2280-v3.txt
>
>
> StreamIn.requestRanges only specifies a keyspace, meaning that requesting a
> range will request it for all column families: if you have a large number of
> CFs, this can cause quite a headache.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
