[
https://issues.apache.org/jira/browse/CASSANDRA-2280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13038600#comment-13038600
]
Sylvain Lebresne commented on CASSANDRA-2280:
---------------------------------------------
* In SSTableLoader, calling Table.open() isn't really neat in that in the case
of the 'external' bulk loader, it's a fat client, so that will imply creating
directories, etc... for no good reason (I haven't test but I would be surprised
it actually throw an exception). We'd better give an empty list. Or even better
(in my opinion), my next point.
* I don't find that very "logic" for streamOutSession to take a collection of
cfs. The coupling seems unnecessary. The problem we're solving is to ask
another node to transfer us some range for some CF. So what about having the
list of CFs only in StreamRequestMessage and add the list of cfs to use as an
argument to StreamOut.transferRanges() ? We don't need it anywhere else.
* In StreamRequestMessage, we should write the operation type even if version
is VERSION_080 (same for deserialization). Nitpick: and couldn't we use the cf
ids instead of the names ?
* In StreamRequestMessage, the field is a Collection but we're still using
Iterables.size() inside. Pretty sure that doesn't leave much option :) I mean,
my remark was more about saying "why add something that may make people wonder
for no reason" since that's not something that is widespread in the code.
Anyway, just saying, I don't care.
* I suppose the bump of MessagingService from 2 to 81 was on purpose ? (I don't
mind, just pointing out to make sure)
> Request specific column families using StreamIn
> -----------------------------------------------
>
> Key: CASSANDRA-2280
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2280
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Stu Hood
> Assignee: Jonathan Ellis
> Fix For: 0.8.1
>
> Attachments:
> 0001-Allow-specific-column-families-to-be-requested-for-str.txt,
> 0001-Allow-specific-column-families-to-be-requested-for-str.txt, 2280-v3.txt,
> 2280-v4.txt
>
>
> StreamIn.requestRanges only specifies a keyspace, meaning that requesting a
> range will request it for all column families: if you have a large number of
> CFs, this can cause quite a headache.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
