[
https://issues.apache.org/jira/browse/CASSANDRA-15909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17155406#comment-17155406
]
Stephen Mallette commented on CASSANDRA-15909:
----------------------------------------------
I've beat this one back and forth a bunch in terms of how to best implement
this. Ultimately I chose to just keep the changes fairly focused in on where
the "deprecation" occurred with the metrics so as not to overhaul too much
existing code. I imagine it would have been nicer to build the concept of
"metric deprecation" into the {{CassandraMetricsRegistry}} a bit more as a
first class feature of it, but given the proximity to release of 4.0 it is
perhaps best to save such larger changes for a future date.
My changes can be reviewed here:
https://github.com/spmallette/cassandra/pull/2
As I alluded to earlier, when this change merges I will rebase CASSANDRA-15821
and make the appropriate documentation changes there. Those documentation
changes will probably be necessary to explain the slightly differently named
metrics that now appear in JMX.
> Make Table/Keyspace Metric Names Consistent With Each Other
> -----------------------------------------------------------
>
> Key: CASSANDRA-15909
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15909
> Project: Cassandra
> Issue Type: Improvement
> Components: Observability/Metrics
> Reporter: Stephen Mallette
> Assignee: Stephen Mallette
> Priority: Normal
> Fix For: 4.0-beta
>
>
> As part of CASSANDRA-15821 it became apparent that certain metric names found
> in keyspace and tables had different names but were in fact the same metric -
> they are as follows:
> * Table.SyncTime == Keyspace.RepairSyncTime
> * Table.RepairedDataTrackingOverreadRows == Keyspace.RepairedOverreadRows
> * Table.RepairedDataTrackingOverreadTime == Keyspace.RepairedOverreadTime
> * Table.AllMemtablesHeapSize == Keyspace.AllMemtablesOnHeapDataSize
> * Table.AllMemtablesOffHeapSize == Keyspace.AllMemtablesOffHeapDataSize
> * Table.MemtableOnHeapSize == Keyspace.MemtableOnHeapDataSize
> * Table.MemtableOffHeapSize == Keyspace.MemtableOffHeapDataSize
> Also, client metrics are the only metrics to start with a lower case letter.
> Change those to upper case to match all the other metrics.
> Unifying this naming would help make metrics more consistent as part of
> CASSANDRA-15582
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
