[
https://issues.apache.org/jira/browse/CASSANDRA-13994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17156999#comment-17156999
]
Ekaterina Dimitrova edited comment on CASSANDRA-13994 at 7/13/20, 10:12 PM:
----------------------------------------------------------------------------
[~slebresne] post review changes done and committed to this [pull request |
https://github.com/ekaterinadimitrova2/cassandra/pull/30] . I didn't squash the
commits so you can easily identify the latest changes. I will do it + remove
the CircleCI custom config as soon as we agree on the final version of the
patch.
CI looks good to me:
[JAVA8 |
https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/275/workflows/8bb7dda4-0ba2-491c-bc85-dd96814f8bfb]
[JAVA 11 |
https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/275/workflows/e61bcd92-d57f-42e9-8771-1b883863f93d]
The failures are not related.
Unfortunately, on CircleCI this is the best we can get from the upgrade tests
due to resource allocation issues.
[~mck], is it possible to run them in Jenkins at the moment?
was (Author: e.dimitrova):
[~slebresne] post review changes done and committed to this [pull request |
https://github.com/ekaterinadimitrova2/cassandra/pull/30] .
CI looks good to me:
[JAVA8 |
https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/275/workflows/8bb7dda4-0ba2-491c-bc85-dd96814f8bfb]
[JAVA 11 |
https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/275/workflows/e61bcd92-d57f-42e9-8771-1b883863f93d]
The failures are not related.
Unfortunately, on CircleCI this is the best we can get from the upgrade tests
due to resource allocation issues.
[~mck], is it possible to run them in Jenkins at the moment?
> Remove dead compact storage code before 4.0 release
> ---------------------------------------------------
>
> Key: CASSANDRA-13994
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13994
> Project: Cassandra
> Issue Type: Improvement
> Components: Legacy/Local Write-Read Paths
> Reporter: Alex Petrov
> Assignee: Ekaterina Dimitrova
> Priority: Low
> Fix For: 4.0, 4.0-beta
>
>
> 4.0 comes without thrift (after [CASSANDRA-11115]) and COMPACT STORAGE (after
> [CASSANDRA-10857]), and since Compact Storage flags are now disabled, all of
> the related functionality is useless.
> There are still some things to consider:
> 1. One of the system tables (built indexes) was compact. For now, we just
> added {{value}} column to it to make sure it's backwards-compatible, but we
> might want to make sure it's just a "normal" table and doesn't have redundant
> columns.
> 2. Compact Tables were building indexes in {{KEYS}} mode. Removing it is
> trivial, but this would mean that all built indexes will be defunct. We could
> log a warning for now and ask users to migrate off those for now and
> completely remove it from future releases. It's just a couple of classes
> though.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
