[ https://issues.apache.org/jira/browse/CASSANDRA-13994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17177949#comment-17177949 ]
Ekaterina Dimitrova edited comment on CASSANDRA-13994 at 8/14/20, 5:14 PM: --------------------------------------------------------------------------- Thank you for the review and the additional suggestions which I cherry-picked to the patch [~slebresne] CI results after rebase and the addition of your commit look good to me: [JAVA8|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/296/workflows/953f79e3-7416-4375-82cf-3dcfeda61ab3] [JAVA11|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/296/workflows/f60d6eca-8bd1-4d68-add7-0a13c35f4695] * stMessagePurging - org.apache.cassandra.net.ConnectionTest - CASSANDRA-15958; failing both for Java 8 and Java 11 * test_simple_parallel_repair - repair_tests.repair_test.TestRepair - not related, I will add it to be checked with CASSANDRA-15986; Java 8 * j11_cqlsh-dtests-py38-with-vnodes show they failed but they passed, there was at the end some circle resource issue * test_resumable_rebuild - rebuild_test.TestRebuild - failing in java 11; CASSANDRA-15892 * test_dead_sync_initiator - repair_tests.repair_test.TestRepair - CASSANDRA-15963 * test_authentication_handle_unavailable - auth_test.TestAuthUnavailable - java 11 - not related; have to check whether a ticket is needed * The upgrade tests that are failing for reason different than No Host Available(test_static_columns_with_2i and upgrade_udtfix_test) were already failing on trunk in Jenkins: * [https://ci-cassandra.apache.org/job/Cassandra-trunk-dtest-upgrade/1/#showFailuresLink] Commits squashed and custom CircleCI config file removed [here |https://github.com/ekaterinadimitrova2/cassandra/commit/e7de05c5ca70fa59aab622f2df41529971e63fb6] was (Author: e.dimitrova): Thank you for the review and the additional suggestions which I cherry-picked to the patch [~slebresne] CI results after rebase and adding your commit look good to me: [JAVA8|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/296/workflows/953f79e3-7416-4375-82cf-3dcfeda61ab3] [JAVA11|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/296/workflows/f60d6eca-8bd1-4d68-add7-0a13c35f4695] * stMessagePurging - org.apache.cassandra.net.ConnectionTest - CASSANDRA-15958; failing both for Java 8 and Java 11 * test_simple_parallel_repair - repair_tests.repair_test.TestRepair - not related, I will add it to be checked with CASSANDRA-15986; Java 8 * j11_cqlsh-dtests-py38-with-vnodes show they failed but they passed, there was at the end some circle resource issue * test_resumable_rebuild - rebuild_test.TestRebuild - failing in java 11; CASSANDRA-15892 * test_dead_sync_initiator - repair_tests.repair_test.TestRepair - CASSANDRA-15963 * test_authentication_handle_unavailable - auth_test.TestAuthUnavailable - java 11 - not related; have to check whether a ticket is needed * The upgrade tests that are failing for reason different than No Host Available(test_static_columns_with_2i and upgrade_udtfix_test) were already failing on trunk in Jenkins: * [https://ci-cassandra.apache.org/job/Cassandra-trunk-dtest-upgrade/1/#showFailuresLink] Commits squashed and custom CircleCI config file removed [here |https://github.com/ekaterinadimitrova2/cassandra/commit/e7de05c5ca70fa59aab622f2df41529971e63fb6] > Remove dead compact storage code before 4.0 release > --------------------------------------------------- > > Key: CASSANDRA-13994 > URL: https://issues.apache.org/jira/browse/CASSANDRA-13994 > Project: Cassandra > Issue Type: Improvement > Components: Legacy/Local Write-Read Paths > Reporter: Alex Petrov > Assignee: Ekaterina Dimitrova > Priority: Low > Fix For: 4.0, 4.0-beta > > > 4.0 comes without thrift (after [CASSANDRA-11115]) and COMPACT STORAGE (after > [CASSANDRA-10857]), and since Compact Storage flags are now disabled, all of > the related functionality is useless. > There are still some things to consider: > 1. One of the system tables (built indexes) was compact. For now, we just > added {{value}} column to it to make sure it's backwards-compatible, but we > might want to make sure it's just a "normal" table and doesn't have redundant > columns. > 2. Compact Tables were building indexes in {{KEYS}} mode. Removing it is > trivial, but this would mean that all built indexes will be defunct. We could > log a warning for now and ask users to migrate off those for now and > completely remove it from future releases. It's just a couple of classes > though. -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org