[
https://issues.apache.org/jira/browse/CASSANDRA-15876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17160248#comment-17160248
]
David Capwell commented on CASSANDRA-15876:
-------------------------------------------
*
https://github.com/ekaterinadimitrova2/cassandra/commit/e05a927fb6787dbf887dd827b07dd02dc5d09e04#diff-28d0b1faa6709eb626f8a04f5e50e18fR28
extra space added, maybe remove?
*
https://github.com/ekaterinadimitrova2/cassandra/commit/e05a927fb6787dbf887dd827b07dd02dc5d09e04#diff-28d0b1faa6709eb626f8a04f5e50e18fR31
Should use immutable sets rather than mutable sets if you expose as being
public.
* Should rename
https://github.com/ekaterinadimitrova2/cassandra/commit/e05a927fb6787dbf887dd827b07dd02dc5d09e04#diff-28d0b1faa6709eb626f8a04f5e50e18fR76
so its clear its from env and not system property. Env may be different than
system property, and the system property matches the actual JVM. Since the
code using it used JAVA_HOME I am fine with this method, but would be best to
rename so its clear.
* Javadocs normally have the description before the annotations, can you double
check that the generated java docs worked correctly for SysPropertiesConfig?
*
https://github.com/ekaterinadimitrova2/cassandra/commit/e05a927fb6787dbf887dd827b07dd02dc5d09e04#diff-28d0b1faa6709eb626f8a04f5e50e18fR215
JMX properties should be prefixed with JMX I think, so its clear what access
file its for
*
https://github.com/ekaterinadimitrova2/cassandra/commit/e05a927fb6787dbf887dd827b07dd02dc5d09e04#diff-28d0b1faa6709eb626f8a04f5e50e18fR248
Can you rename the mx4j properties to say mx4j in the method name? saddress
isn't clear
*
https://github.com/ekaterinadimitrova2/cassandra/commit/e05a927fb6787dbf887dd827b07dd02dc5d09e04#r40555216
Agree that it would be better to rewrite so we don't duplicate. If we used a
enum then we remove the listing and duplication issue.
Overall I am +1 for this patch; all my comments are small.
> Accessors for SystemProperties
> ------------------------------
>
> Key: CASSANDRA-15876
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15876
> Project: Cassandra
> Issue Type: Improvement
> Components: Local/Config
> Reporter: Ekaterina Dimitrova
> Assignee: Ekaterina Dimitrova
> Priority: Low
> Fix For: 4.0, 4.0-beta
>
>
> As part of CASSANDRA-15234, it was suggested a class of accessors for System
> properties to be created for better clarity and maintainability.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
