[
https://issues.apache.org/jira/browse/CASSANDRA-15876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17180164#comment-17180164
]
David Capwell commented on CASSANDRA-15876:
-------------------------------------------
* Since you are using getter, should make the field private:
https://github.com/ekaterinadimitrova2/cassandra/commit/a269216be895995de36de765e22cc0fd53b20115#diff-67567e4c45fc05832fecc525f2a08be0R42
* Same, should use private
https://github.com/ekaterinadimitrova2/cassandra/commit/a269216be895995de36de765e22cc0fd53b20115#diff-aa726f08e6baa983bcd860797e60d8a2R88
* nit: rather than convert default before calling method, why not do it
If-and-only-if default is accessed? It unifies the conversation logic (int has
2 different logics to convert).
https://github.com/ekaterinadimitrova2/cassandra/commit/a269216be895995de36de765e22cc0fd53b20115#diff-aa726f08e6baa983bcd860797e60d8a2R122
* Make all the converters private, the interface is but the field isn't:
https://github.com/ekaterinadimitrova2/cassandra/commit/a269216be895995de36de765e22cc0fd53b20115#diff-aa726f08e6baa983bcd860797e60d8a2R136
* This is my personal preference, so not a blocker. I feel that we should
remove the functions in favor of just hitting the enum. I feel that over time
people won't add the functions, it will cause confusion "which one should I
use", and makes the code more verbose.
https://github.com/ekaterinadimitrova2/cassandra/commit/a269216be895995de36de765e22cc0fd53b20115#diff-aa726f08e6baa983bcd860797e60d8a2R151
Getting pulled away, ill look at the other changes in a bit
> Accessors for SystemProperties
> ------------------------------
>
> Key: CASSANDRA-15876
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15876
> Project: Cassandra
> Issue Type: Improvement
> Components: Local/Config
> Reporter: Ekaterina Dimitrova
> Assignee: Ekaterina Dimitrova
> Priority: Low
> Fix For: 4.0, 4.0-beta
>
>
> As part of CASSANDRA-15234, it was suggested a class of accessors for System
> properties to be created for better clarity and maintainability.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
