[
https://issues.apache.org/jira/browse/CASSANDRA-15968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17166473#comment-17166473
]
Jon Meredith commented on CASSANDRA-15968:
------------------------------------------
Thanks for the patch. I did a quick first pass, not sure whether to leave
comments here or against the individual commits. Generally it looks good, just
a few nits and I'll do a second pass to look over the changes to shutdown.
HintsService:
Could you log on duplicate shutdown attempts (just an info) like
MessagingService - "Hints service already shutting down, ignoring."
Instance.java: Nit: In Instance.java, why did you put the registerDaemon call
between the todo comment and the has(GOSSIP) clause? It seems cheap enough to
register, not sure why it wasn't before.
Gossiper.java: Can you correct the log message on repeat shutdown to indicate
Gossiper.
Nit: If MessagingService can be restarted, wasShutdown could be renamed
isShutdown as that implies state rather than history.
> nodetool drain fails in jvm dtest
> ---------------------------------
>
> Key: CASSANDRA-15968
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15968
> Project: Cassandra
> Issue Type: Bug
> Components: Test/dtest
> Reporter: David Capwell
> Assignee: David Capwell
> Priority: Normal
> Fix For: 2.2.x, 3.0.x, 3.11.x, 4.0-beta
>
>
> Drain fails since MessagingService doesn’t expect to be shutdown twice.
> {code}
> Caused by: java.lang.AssertionError
> at
> org.apache.cassandra.net.MessagingService.shutdown(MessagingService.java:766)
> at
> org.apache.cassandra.distributed.impl.Instance.lambda$parallelRun$28(Instance.java:805)
> at java.util.concurrent.FutureTask.run(FutureTask.java:266)
> ... 3 more
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
