[
https://issues.apache.org/jira/browse/CASSANDRA-15968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17166528#comment-17166528
]
David Capwell commented on CASSANDRA-15968:
-------------------------------------------
thanks for the review, ill work to address those comments.
bq. why did you put the registerDaemon call between the todo comment and the
has(GOSSIP) clause?
https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/service/CassandraDaemon.java#L370-L375
Mostly trying to keep the logic in the same order as CassandraDaemon.
bq. It seems cheap enough to register, not sure why it wasn't before.
One of the bad parts of the Instance setup, we need to replicate 100% of
cassandra daemon startup, but we don't use it directly... so some things like
this get missed.
> nodetool drain fails in jvm dtest
> ---------------------------------
>
> Key: CASSANDRA-15968
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15968
> Project: Cassandra
> Issue Type: Bug
> Components: Test/dtest
> Reporter: David Capwell
> Assignee: David Capwell
> Priority: Normal
> Fix For: 2.2.x, 3.0.x, 3.11.x, 4.0-beta
>
>
> Drain fails since MessagingService doesn’t expect to be shutdown twice.
> {code}
> Caused by: java.lang.AssertionError
> at
> org.apache.cassandra.net.MessagingService.shutdown(MessagingService.java:766)
> at
> org.apache.cassandra.distributed.impl.Instance.lambda$parallelRun$28(Instance.java:805)
> at java.util.concurrent.FutureTask.run(FutureTask.java:266)
> ... 3 more
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
