[
https://issues.apache.org/jira/browse/CASSANDRA-16183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17227474#comment-17227474
]
Andres de la Peña commented on CASSANDRA-16183:
-----------------------------------------------
We don't merge the PRs nor require them, but I found them useful for the review
comments, and in my experience it's usual to have them for that purpose (see
[here|https://github.com/apache/cassandra/pulls] and
[here)|https://github.com/apache/cassandra-dtest/pulls], although tickets
without PR are not unusual either. I think that without a PR we can only add
comments on each of the nine individual commits, but not on the diff, so it's
difficult to have a global vision. Also I'm not sure whether those comments
would survive a squash, as they do with PRs. WDYT? I can create the PR if you
don't disagree, or perhaps we can squash the changes and comment on a single
commit.
> Add tests to cover ClientRequest metrics
> -----------------------------------------
>
> Key: CASSANDRA-16183
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16183
> Project: Cassandra
> Issue Type: Improvement
> Components: Test/dtest/java
> Reporter: Benjamin Lerer
> Assignee: Adam Holmberg
> Priority: Normal
> Fix For: 4.0-beta
>
>
> We do not have test that covers the ClientRequest metrics.
> * ClientRequestMetrics
> * CASClientRequestMetrics
> * CASClientWriteRequestMetrics
> * ClientWriteRequestMetrics
> * ViewWriteMetrics
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
