[
https://issues.apache.org/jira/browse/CASSANDRA-16183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17229398#comment-17229398
]
Andres de la Peña commented on CASSANDRA-16183:
-----------------------------------------------
Fair enough, I was just trying to be exhaustive with tested inputs there and I
didn't see any problems with {{Count}}, but indeed adding more consistency
levels doesn't give us a lot of additional value, so I'm happy with leaving it
as it is.
{quote}One thing I noted while creating this test: While {{ViewWriteMetrics}}
inherits from {{ClientRequestMetrics}}, none of the [additional
members|https://github.com/aholmberg/cassandra/blob/93c2d763eb5107c2001384700be4b240ecf7a4b8/src/java/org/apache/cassandra/metrics/ClientRequestMetrics.java#L31-L33]
from that class are used. Would it be worth deprecating
{{ViewWriteMetrics.timeouts}}, etc and making that class derive directly from
{{LatencyMetrics}} in a later release, or should we just leave it?
{quote}
I wonder if MVs should be updating those meters, at least it seems to me that
it could make sense to update those meters for MV mutations in the same way
that we do with regular and CAS mutations. Alternatively, if we drop them and
{{ViewWriteMetrics}} inherits directly from {{LatencyMetrics}} it would stop
having the {{ClientRequest}} type as part of the mbean name, what could be
correct if we consider MV mutations an internal request instead of a client
request. Although that change in naming could be a bit confuse for the user.
Anyway, I understand that MVs are still considered experimental and not a
priority for 4.0, so perhaps we could move that discussion to a separate
ticket, WDYT?
Here I've started dtest runs in ci-cassandra:
[https://ci-cassandra.apache.org/view/all/job/Cassandra-devbranch-dtest/187/]
[https://ci-cassandra.apache.org/view/all/job/Cassandra-devbranch-dtest-novnode/3/]
> Add tests to cover ClientRequest metrics
> -----------------------------------------
>
> Key: CASSANDRA-16183
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16183
> Project: Cassandra
> Issue Type: Improvement
> Components: Test/dtest/java
> Reporter: Benjamin Lerer
> Assignee: Adam Holmberg
> Priority: Normal
> Fix For: 4.0-beta
>
>
> We do not have test that covers the ClientRequest metrics.
> * ClientRequestMetrics
> * CASClientRequestMetrics
> * CASClientWriteRequestMetrics
> * ClientWriteRequestMetrics
> * ViewWriteMetrics
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
