[
https://issues.apache.org/jira/browse/CASSANDRA-16180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17246856#comment-17246856
]
Blake Eggleston commented on CASSANDRA-16180:
---------------------------------------------
Regarding the audit, the work here seems to mainly be focused on partition
range reads. Between CASSANDRA-16180 and CASSANDRA-16181, I think we also need
to look at writes (including batches), single partition reads, and paging. If
we want to scope this ticket to _just_ range reads, that's fine, but we should
then create some additional subtasks for CASSANDRA-15579.
Some dtests that aren't included in the doc for either ticket are:
* multidc_putget_test.py
* pending_range_test.py
* putget_test.py
* paging_test.py
It may also be helpful to drop the distinction between coordination and
replication, since testing the distributed read write path is really looking at
the coordination of client queries, and client writes are just one component of
C* replication </bikeshed>
Code wise, things look good so far for the most part. The 2 suggestions I have
at this point are:
First, the multi-line assignment format in RangeCommandIterator should be
fixed (indent before `=` in `query`)
Second, RangeCommandExecutor could be streamlined a bit. I get that we want
the range command iterator to be accessible for testing, but we shouldn't be
allocating objects on the heap in production just for that. This could be
reworked into a couple of static methods that would create a command iterator
and another that would create a partition iterator. That would support testing
and avoid any unneccesary allocations. Given that change, a better name for the
class would probably be RangeCommands, or something.
> 4.0 Quality: Coordination Test Audit
> ------------------------------------
>
> Key: CASSANDRA-16180
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16180
> Project: Cassandra
> Issue Type: Task
> Components: Test/unit
> Reporter: Andres de la Peña
> Assignee: Andres de la Peña
> Priority: Normal
> Fix For: 4.0
>
> Time Spent: 8.5h
> Remaining Estimate: 0h
>
> This is a subtask of CASSANDRA-15579 focusing on coordination.
> I think that the main reference dtest for this is
> [consistency_test.py|https://github.com/apache/cassandra-dtest/blob/master/consistency_test.py].
> We should identify which other tests cover this and identify what should be
> extended, similarly to what has been done with CASSANDRA-15977.
> [This
> document|https://docs.google.com/document/d/1BBeGKla9tIPflZ2awkyfl5Hc_FTs3QYw98LWUnb1fTQ/edit?usp=sharing]
> aims to list and describe the existing functional tests for coordination, so
> we can have a broad view of what is currently covered.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
