[
https://issues.apache.org/jira/browse/CASSANDRA-16180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17247338#comment-17247338
]
Andres de la Peña commented on CASSANDRA-16180:
-----------------------------------------------
bq. First, the multi-line assignment format in RangeCommandIterator should be
fixed (indent before `=` in `query`)
Done
[here|https://github.com/apache/cassandra/pull/801/commits/bbe4d6ca6fb1c6620c318605190b472884983da5].
For some reason my IntelliJ with the project's codestyle insists on removing
those indents.
bq. Second, RangeCommandExecutor could be streamlined a bit. I get that we want
the range command iterator to be accessible for testing, but we shouldn't be
allocating objects on the heap in production just for that. This could be
reworked into a couple of static methods that would create a command iterator
and another that would create a partition iterator. That would support testing
and avoid any unneccesary allocations. Given that change, a better name for the
class would probably be RangeCommands, or something.
I tried to do so
[here|https://github.com/apache/cassandra/pull/801/commits/02affa9dcf96fd8fcbca6247a38ff19e1f1ffc7e].
The reason for having an instantiable {{RangeCommandExecutor}} was to be able
to have multiple implementations of it this executor the future, when we
integrate SAI. But we aren't in that point yet, and when we get there this will
be easy to change it back if needed.
> 4.0 Quality: Coordination Test Audit
> ------------------------------------
>
> Key: CASSANDRA-16180
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16180
> Project: Cassandra
> Issue Type: Task
> Components: Test/unit
> Reporter: Andres de la Peña
> Assignee: Andres de la Peña
> Priority: Normal
> Fix For: 4.0
>
> Time Spent: 9h 10m
> Remaining Estimate: 0h
>
> This is a subtask of CASSANDRA-15579 focusing on coordination.
> I think that the main reference dtest for this is
> [consistency_test.py|https://github.com/apache/cassandra-dtest/blob/master/consistency_test.py].
> We should identify which other tests cover this and identify what should be
> extended, similarly to what has been done with CASSANDRA-15977.
> [This
> document|https://docs.google.com/document/d/1BBeGKla9tIPflZ2awkyfl5Hc_FTs3QYw98LWUnb1fTQ/edit?usp=sharing]
> aims to list and describe the existing functional tests for coordination, so
> we can have a broad view of what is currently covered.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
