[ 
https://issues.apache.org/jira/browse/CASSANDRA-16355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17285143#comment-17285143
 ] 

Benjamin Lerer commented on CASSANDRA-16355:
--------------------------------------------

I digged into the tests and it seems that the issue is that the timeouts are 
probably to low for the  CI environment. I noticed that the initial insert 
query is slower to reach the paxos logic that the following ones.

For the {{incompletePropose}} test, what is happening is that the initial 
insert timeout in the {{prepare}} round before this phase is actually completed 
on the node. Due to that the original update is never taken into account. The 
following update fail silently and the problem is caught by the {{SELECT}} 
query.
Another scenario that can happen is that the {{prepare}} round complete but the 
{{proposal}} one fail for the coordinator node due to a timeout. In this case 
the following update will found the prepared value and ensure that it is 
proposed and committed before applying the update. So in practice the test will 
succeed even if the executed scenario is not the expected one.

For the {{incompleteCommit}} test what is happening  is due to the extra work 
left by the original insert the update take longer than expected and timeout. 

 
 

> Fix flaky test incompletePropose - 
> org.apache.cassandra.distributed.test.CASTest
> --------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-16355
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-16355
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Feature/Lightweight Transactions, Test/dtest/java
>            Reporter: David Capwell
>            Assignee: Benjamin Lerer
>            Priority: Normal
>             Fix For: 4.0-beta
>
>
> https://app.circleci.com/pipelines/github/dcapwell/cassandra/853/workflows/0766c0de-956e-4831-aa40-9303748a2708/jobs/5030
> {code}
> junit.framework.AssertionFailedError: Expected: [[1, 1, 2]]
> Actual: []
>       at 
> org.apache.cassandra.distributed.shared.AssertUtils.fail(AssertUtils.java:193)
>       at 
> org.apache.cassandra.distributed.shared.AssertUtils.assertEquals(AssertUtils.java:163)
>       at 
> org.apache.cassandra.distributed.shared.AssertUtils.assertRows(AssertUtils.java:63)
>       at 
> org.apache.cassandra.distributed.test.CASTest.incompletePropose(CASTest.java:124)
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to